❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

Hi @pasha-codefresh , @reggie-k , because you reviewed #16871 , could you please review this PR change? This PR will remove the Show/Hide button.

Here is an example multi-source app for test purposes.

project: default
destination:
  server: https://kubernetes.default.svc
  namespace: default
sources:
  - repoURL: https://github.com/keithchong/argocd-example-apps.git
    path: helm-guestbook
    targetRevision: HEAD
    helm: {}
  - repoURL: https://github.com/keithchong/values-files.git
    targetRevision: HEAD
    ref: values_test

Sure @keithchong , we will allocate time and will review it

@CodiumAI-Agent /review

PR Reviewer Guide 🔍

(Review updated until commit d67b7a9)

Here are some key observations to aid the review process:

I have checked manually, change looks good

Persistent review updated to latest commit d67b7a9

Thanks a lot for this fix, @keithchong!

I have tested manually and this panel looks much better than the button and better integrates with the ArgoCD UI overall.

One thing I liked about the button was that I could press on exactly the same location on the screen to both show and hide, while with the new panel I could click anywhere on the panel it to expand it, but can only click on the arrow to collapse, and I also think that the arrow needs to be a bit more visible in dark mode.

WDYT?

Here is the reason why I have the expand/collapse behaviour this way.

1. The collapsed version of these sections look pretty much the same as those cards shown in the Settings page. I wanted to have the same look and feel. However, instead of the arrow pointing to the right as in the Settings page, these arrows will be pointing down, to indicate the collapsed state. In the Settings page, you can also click any where on the card to bring you to the next page. Here, for the collapsed section, I wanted to maintain that behaviour. However, we could just as easily force the user to click on the drop-down arrow too, but the current way makes it easier. (Note that if we were using a standard framework, like Patternfly or Carbon, we would simply just use whatever widget they provide.)
2. After the section is expanded, you must click on the up-arrow to collapse it, as you've discovered. This must be the case because users may want to copy the field values, so they must be able to click to select the text (instead of collapsing the section).

The arrows are currently the same colour in dark mode as those arrows in the Settings page. i agree that it can be brighter, so I made the changes:

Collapsed:

Expanded:

@pasha-codefresh , @reggie-k - updated and rebased. Thanks for your time again.

Thanks for the making the arrow look better in dark mode, Keith.
So I understand we cannot make it both collapsible and text-selectable?
Actually, expanding/collapsing the "SYNC STATUS" on the left filters sidebar is available by clicking on the arrow only and not on the entire row.
I think having the panel collapsible and text searchable would be nice, not mandatory, but if it is complicated to achieve, maybe we can enforce collapsing/expanding by clicking the arrow only, like in left filters sidebar, or just leave it as is, up to you.
I don't have a really strong opinion from a UX point of view and this LGTM also as it is right now.

Thanks @reggie-k , I'll leave it for now, and if people complain about how it works, we can revisit it in another PR.