chore(server): better error message for missing action (#20408) #20409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
crenshaw-dev
commented
Oct 16, 2024
| @@ -24,13 +24,22 @@ import ( | |||
|
|
|||
| const ( | |||
| incorrectReturnType = "expect %s output from Lua script, not %s" | |||
| incorrectInnerType = "expect %s inner type from Lua script, not %s" | |||
There was a problem hiding this comment.
This field isn't used anymore, just deleted it while I was in here.
crenshaw-dev
commented
Oct 16, 2024
| @@ -266,7 +266,7 @@ func TestGetHealthScriptNoPredefined(t *testing.T) { | |||
| vm := VM{} | |||
| script, useOpenLibs, err := vm.GetHealthScript(testObj) | |||
| require.NoError(t, err) | |||
| assert.True(t, useOpenLibs) | |||
| assert.False(t, useOpenLibs) | |||
There was a problem hiding this comment.
Returning false is fine, this return value won't be used when the returned script is "".
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20409 +/- ##
==========================================
+ Coverage 56.02% 56.05% +0.03%
==========================================
Files 322 322
Lines 44802 44810 +8
==========================================
+ Hits 25099 25119 +20
+ Misses 17104 17096 -8
+ Partials 2599 2595 -4 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
commented
Oct 17, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
nitishfy
reviewed
Oct 17, 2024
| var doesNotExist *ScriptDoesNotExistError | ||
| if errors.As(err, &doesNotExist) { | ||
| // It's okay if no built-in health script exists. Just return an empty string and let the caller handle it. | ||
| return "", false, nil |
There was a problem hiding this comment.
Suggested change
| return "", false, nil | |
| return "", false, nil |
why are we returning error as nil here?
There was a problem hiding this comment.
Per the comment "It's okay if no built-in health script exists. Just return an empty string and let the caller handle it."
Absence of a health check isn't a problem in the context of this function. We just skip health checks for that resource.
4ch3los
pushed a commit
to 4ch3los/argo-cd
that referenced
this pull request
Oct 17, 2024
… (argoproj#20409) * chore(server): better error message for missing action Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update util/lua/lua_test.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
6 tasks
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this pull request
Dec 4, 2024
… (argoproj#20409) * chore(server): better error message for missing action Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update util/lua/lua_test.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20408
The output is much nicer: