Skip to content

feat: Enable ignoreResourceUpdate by default #19992 #20303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2024
Merged

feat: Enable ignoreResourceUpdate by default #19992 #20303

merged 1 commit into from
Oct 10, 2024

Conversation

jaehanbyun
Copy link
Member

@jaehanbyun jaehanbyun commented Oct 9, 2024 •
edited by agaudreault
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

What I have done:

  • Enable ignoreResourceUpdate by default

@jaehanbyun jaehanbyun requested a review from a team as a code owner October 9, 2024 05:19
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Oct 9, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.99%. Comparing base (82484ce) to head (3bb5034).
Report is 395 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20303      +/-   ##
==========================================
+ Coverage   55.94%   55.99%   +0.04%     
==========================================
  Files         322      322              
  Lines       44704    44704              
==========================================
+ Hits        25011    25031      +20     
+ Misses      17104    17077      -27     
- Partials     2589     2596       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nitishfy
nitishfy approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crenshaw-dev
Copy link
Member

Please also update documentation

@jaehanbyun jaehanbyun requested a review from a team as a code owner October 9, 2024 15:50
@jaehanbyun
Copy link
Member Author

jaehanbyun commented Oct 9, 2024 •
edited
Loading

@crenshaw-dev I updated documentation. Thanks!

crenshaw-dev
crenshaw-dev previously requested changes Oct 9, 2024
View reviewed changes
docs/operator-manual/argocd-cm.yaml
Comment on lines +110 to +111
# to resources are applied to the cluster cache. Default is true.
resource.ignoreResourceUpdatesEnabled: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the docs in reconcile.md?

@jaehanbyun
Copy link
Member Author

@crenshaw-dev I'm not sure if the option has been well explained, PTAL!

@jaehanbyun
feat: Enable ignoreResourceUpdate by default
3bb5034 
Signed-off-by: jaehanbyun <awbrg789@naver.com>
christianh814
christianh814 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@christianh814 christianh814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs to resolve feedback from Crenshaw but other than that LGTM

agaudreault
agaudreault approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@agaudreault agaudreault left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We discussed it a bit today in the SIG Scalability. I have been involved in monitoring the usage of this feature through slack and GitHub issues, i haven't seen any negative impact after enabling it with the default configurations.

Obviously, it still needs to be configured to improve the performance significantly. Perhaps 3.0 can include default configuration for known resources (#19992) so i don't think it fully closes the issue.

Let's bring it up at the next contributors meeting just in case, but it's safe to merge after that IMO.

@jaehanbyun
Copy link
Member Author

@agaudreault Understood. Please let me know if there are any additional details related to this PR after the meeting. Thanks!

@agaudreault agaudreault enabled auto-merge (squash) October 10, 2024 16:38
@agaudreault agaudreault merged commit 8ebf4a8 into argoproj:master Oct 10, 2024
28 checks passed
austin5219 pushed a commit to austin5219/argo-cd that referenced this pull request Oct 16, 2024
@jaehanbyun @austin5219
feat: Enable ignoreResourceUpdate by default argoproj#19992 (argoproj…
b60a200 
…#20303)

Signed-off-by: jaehanbyun <awbrg789@naver.com>
Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
@jaehanbyun jaehanbyun mentioned this pull request Oct 25, 2024
Closed
6 tasks
@nitishfy nitishfy mentioned this pull request Oct 25, 2024
Closed
6 tasks
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@jaehanbyun @adriananeci
feat: Enable ignoreResourceUpdate by default argoproj#19992 (argoproj…
e986e3a 
…#20303)

Signed-off-by: jaehanbyun <awbrg789@naver.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumstead rumstead rumstead approved these changes

@agaudreault agaudreault agaudreault approved these changes

@nitishfy nitishfy nitishfy approved these changes

@crenshaw-dev crenshaw-dev crenshaw-dev left review comments

+1 more reviewer

@christianh814 christianh814 christianh814 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jaehanbyun @crenshaw-dev @christianh814 @rumstead @agaudreault @nitishfy