Skip to content

Conversation

mmorel-35
Copy link
Contributor

enables and fixes usestdlibvars linter issues.

@mmorel-35 mmorel-35 requested a review from a team as a code owner October 16, 2024 05:37
Copy link

bunnyshell bot commented Oct 16, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the golangci-lint/usestdlibvars branch from f317487 to 1f848f6 Compare October 16, 2024 05:41
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.02%. Comparing base (e80de49) to head (1f848f6).
Report is 372 commits behind head on master.

Files with missing lines Patch % Lines
server/server.go 0.00% 0 Missing and 1 partial ⚠️
util/kube/failureretrywrapper.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20399      +/-   ##
==========================================
- Coverage   56.04%   56.02%   -0.02%     
==========================================
  Files         322      322              
  Lines       44798    44798              
==========================================
- Hits        25106    25099       -7     
- Misses      17086    17100      +14     
+ Partials     2606     2599       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks @mmorel-35

@ishitasequeira ishitasequeira merged commit e0ebb02 into argoproj:master Oct 16, 2024
27 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/usestdlibvars branch October 16, 2024 13:07
4ch3los pushed a commit to 4ch3los/argo-cd that referenced this pull request Oct 17, 2024
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants