fix(ui): display correct init info in Pod UI #20387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: linghaoSu <linghao.su@daocloud.io>
…play Signed-off-by: linghaoSu <linghao.su@daocloud.io>
6cc0a88 to
e7cd18d
Compare
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> oops Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> indent Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> fix accidental duplication Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
e7cd18d to
016d5af
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20387 +/- ##
==========================================
- Coverage 56.04% 56.01% -0.03%
==========================================
Files 322 322
Lines 44798 44798
==========================================
- Hits 25106 25095 -11
- Misses 17086 17096 +10
- Partials 2606 2607 +1 ☔ View full report in Codecov by Sentry. |
linghaoSu
reviewed
Oct 16, 2024
todaywasawesome
approved these changes
Oct 16, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
christianh814
approved these changes
Oct 16, 2024
ishitasequeira
approved these changes
Oct 17, 2024
4ch3los
pushed a commit
to 4ch3los/argo-cd
that referenced
this pull request
Oct 17, 2024
* fix(controller): change pod status calculate with sidecar Signed-off-by: linghaoSu <linghao.su@daocloud.io> * fix(controller): add restartable sidecar count in total container display Signed-off-by: linghaoSu <linghao.su@daocloud.io> * test UI, fix bugs Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> oops Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> indent Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> fix accidental duplication Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * apply recommendation Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: linghaoSu <linghao.su@daocloud.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: linghaoSu <linghao.su@daocloud.io>
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this pull request
Dec 4, 2024
* fix(controller): change pod status calculate with sidecar Signed-off-by: linghaoSu <linghao.su@daocloud.io> * fix(controller): add restartable sidecar count in total container display Signed-off-by: linghaoSu <linghao.su@daocloud.io> * test UI, fix bugs Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> oops Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> indent Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> fix accidental duplication Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * apply recommendation Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: linghaoSu <linghao.su@daocloud.io> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: linghaoSu <linghao.su@daocloud.io> Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI currently displays incorrect/incomplete information about a Pod's initialization process. This PR takes existing tests from similar backend code and adds them to the frontend code. I also tidied and parallelized the backend tests. I fixed three broken UI behaviors:
)in init messages.reverse()from container status traversal, which was producing inaccurate container countsIgnore whitespace for an easier review: https://github.com/argoproj/argo-cd/pull/20387/files?w=1
The UI in question:
Init: 1)should beInit: 0/1.