feat: add Actions for PipelineRollout to allow/disallow data loss #20298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20298 +/- ##
==========================================
+ Coverage 55.92% 55.96% +0.04%
==========================================
Files 322 322
Lines 44673 44701 +28
==========================================
+ Hits 24985 25019 +34
+ Misses 17094 17082 -12
- Partials 2594 2600 +6 ☔ View full report in Codecov by Sentry. |
ali-hamza-noor
pushed a commit
to ali-hamza-noor/argo-cd
that referenced
this pull request
Oct 10, 2024
…goproj#20298) * add Actions for PipelineRollout to allow/disallow data loss Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> * fix: test, add codegen generated docs Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> * fix name Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> * fix: make actions more robust to handle empty metadata Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> * spacing Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> --------- Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> Signed-off-by: alnoor <alihamzanoor99@gmail.com>
austin5219
pushed a commit
to austin5219/argo-cd
that referenced
this pull request
Oct 16, 2024
…goproj#20298) * add Actions for PipelineRollout to allow/disallow data loss Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> * fix: test, add codegen generated docs Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> * fix name Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> * fix: make actions more robust to handle empty metadata Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> * spacing Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> --------- Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this pull request
Dec 4, 2024
…goproj#20298) * add Actions for PipelineRollout to allow/disallow data loss Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> * fix: test, add codegen generated docs Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> * fix name Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> * fix: make actions more robust to handle empty metadata Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> * spacing Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> --------- Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Open Source Project github.com/numaproj/numaplane is a Control Plane for Numaflow Pipelines.
PipelineRolloutis a CR which wraps around NumaflowPipelineto manage its state.Numaplane has a strategy for safely updating a Numaflow Pipeline to eliminate data loss by initially pausing it.
The "allow-data-loss" Action is a solution to the problem that a Pipeline may get stuck in "pausing" for whatever reason, so the user needs a way to stop the pausing and complete the update. This is done through the use of an annotation on the object.
Checklist: