chore(controller): remove unnecessary field #20295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20295 +/- ##
==========================================
- Coverage 55.98% 55.96% -0.02%
==========================================
Files 322 322
Lines 44701 44700 -1
==========================================
- Hits 25024 25015 -9
- Misses 17080 17095 +15
+ Partials 2597 2590 -7 ☔ View full report in Codecov by Sentry. |
pasha-codefresh
approved these changes
Oct 9, 2024
ali-hamza-noor
pushed a commit
to ali-hamza-noor/argo-cd
that referenced
this pull request
Oct 10, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: alnoor <alihamzanoor99@gmail.com>
austin5219
pushed a commit
to austin5219/argo-cd
that referenced
this pull request
Oct 16, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this pull request
Dec 4, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
repoClientsetargument inNewApplicationControlleris used to constructctrl.appStateManager. But the field on theApplicationControllerstruct isn't actually used for anything but a test. We can remove it to simplify the code.