Skip to content

feat(clusters): Add disableCompression option in the cluster config - Fixes #19259 #20291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

feat(clusters): Add disableCompression option in the cluster config - Fixes #19259 #20291

merged 1 commit into from
Oct 9, 2024

Conversation

OpenGuidou
Copy link
Contributor

@OpenGuidou OpenGuidou commented Oct 8, 2024 •
edited
Loading

Fixes #19259

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@OpenGuidou OpenGuidou requested review from a team as code owners October 8, 2024 13:45
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Oct 8, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@OpenGuidou OpenGuidou changed the title feat(clusters) - Add disableCompression option in the cluster config - Fixes #19259 feat(clusters): Add disableCompression option in the cluster config - Fixes #19259 Oct 8, 2024
@OpenGuidou OpenGuidou force-pushed the kubectlarg branch 2 times, most recently from 82d4ed3 to 8f7ea8b Compare October 8, 2024 14:16
@OpenGuidou OpenGuidou mentioned this pull request Oct 8, 2024
Closed
7 tasks
@speedfl
Copy link
Contributor

speedfl commented Oct 8, 2024

LGTM

@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.96%. Comparing base (dc27102) to head (42a1f7a).
Report is 391 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/cluster.go 0.00% 1 Missing ⚠️
cmd/util/cluster.go 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20291      +/-   ##
==========================================
- Coverage   55.98%   55.96%   -0.02%     
==========================================
  Files         322      322              
  Lines       44701    44705       +4     
==========================================
- Hits        25024    25020       -4     
- Misses      17080    17096      +16     
+ Partials     2597     2589       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OpenGuidou
Copy link
Contributor Author

Hi @crenshaw-dev , would you mind reviewing this one ?

@OpenGuidou
feat(clusters) - Add disableCompression option in the cluster config
42a1f7a 
Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
pasha-codefresh
pasha-codefresh approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@pasha-codefresh pasha-codefresh merged commit 1bbeab7 into argoproj:master Oct 9, 2024
27 checks passed
ali-hamza-noor pushed a commit to ali-hamza-noor/argo-cd that referenced this pull request Oct 10, 2024
@OpenGuidou @ali-hamza-noor
feat(clusters) - Add disableCompression option in the cluster config (a…
7e21e6c 
…rgoproj#20291)

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Signed-off-by: alnoor <alihamzanoor99@gmail.com>
austin5219 pushed a commit to austin5219/argo-cd that referenced this pull request Oct 16, 2024
@OpenGuidou @austin5219
feat(clusters) - Add disableCompression option in the cluster config (a…
c628e91 
…rgoproj#20291)

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@OpenGuidou @adriananeci
feat(clusters) - Add disableCompression option in the cluster config (a…
d2e4002 
…rgoproj#20291)

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Kubectl Option support like disable-compression
3 participants
@OpenGuidou @speedfl @pasha-codefresh