fix: GOLANGCI_LINT_VERSION #20264

dcoppa · 2024-10-07T09:38:23Z

Without this, I get an error while building the master branch of argo-cd:

go: downloading gopkg.in/ini.v1 v1.67.0
go: downloading github.com/magiconair/properties v1.8.7
go: downloading github.com/pelletier/go-toml/v2 v2.0.6
go: downloading golang.org/x/text v0.7.0

export DOWNLOADS=/tmp/dl
DOWNLOADS=/tmp/dl
export BIN=/usr/local/bin
BIN=/usr/local/bin
mkdir -p /tmp/dl
ARCHITECTURE=
case $(uname -m) in
++ uname -m
ARCHITECTURE=amd64
INSTALL_OS=
++ uname -s
unameOut=Linux
case "${unameOut}" in
INSTALL_OS=linux
for product in $*
++ dirname ./install.sh
ARCHITECTURE=amd64
INSTALL_OS=linux
./installers/install-lint-tools.sh
GOLANGCI_LINT_VERSION=1.61.0
GO111MODULE=on
go install github.com/golangci/golangci-lint/cmd/golangci-lint@1.61.0
go: github.com/golangci/golangci-lint/cmd/golangci-lint@1.61.0: github.com/golangci/golangci-lint/cmd/golangci-lint@1.61.0: invalid version: unknown revision 1.61.0
building at STEP "RUN ./install.sh helm && ./install.sh kustomize && ./install.sh codegen-tools && ./install.sh codegen-go-tools && ./install.sh lint-tools && go install github.com/mattn/goreman@latest && go install github.com/kisielk/godepgraph@latest && go install github.com/jstemmer/go-junit-report@latest && rm -rf /tmp/dl && rm -rf /tmp/helm && rm -rf /tmp/ks_*": while running runtime: exit status 1

make: *** [Makefile:276: test-tools-image] Error 1

bunnyshell · 2024-10-07T09:38:28Z

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

🚀 /bns:deploy to deploy the environment

bunnyshell · 2024-10-07T09:38:29Z

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

🚀 /bns:deploy to deploy the environment

Signed-off-by: David Coppa <dcoppa@cocus.com>

….0 (argoproj#19524) Bumps [SonarSource/sonarqube-scan-action](https://github.com/sonarsource/sonarqube-scan-action) from 2.3.0 to 3.0.0. - [Release notes](https://github.com/sonarsource/sonarqube-scan-action/releases) - [Commits](SonarSource/sonarqube-scan-action@aecaf43...0c0f395) --- updated-dependencies: - dependency-name: SonarSource/sonarqube-scan-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: David Coppa <dcoppa@cocus.com>

ggjulio · 2024-10-07T10:30:19Z

hack/installers/install-lint-tools.sh

@@ -2,6 +2,6 @@
 set -eux -o pipefail

 # renovate: datasource=go packageName=github.com/golangci/golangci-lint
-GOLANGCI_LINT_VERSION=1.61.0
+GOLANGCI_LINT_VERSION=v1.61.0

 GO111MODULE=on go install "github.com/golangci/golangci-lint/cmd/golangci-lint@${GOLANGCI_LINT_VERSION}"


It was my fault :

d17aafd#diff-379bb3898b60010b7127603fcc9dcfb4d7f8e921997c1b43eaba78c5a99ce3c8L4

The v should be outside the variable else renovate will either fail updating or won't stop removing it.

- GOLANGCI_LINT_VERSION=v1.61.0 + GOLANGCI_LINT_VERSION=1.61.0 - GO111MODULE=on go install "github.com/golangci/golangci-lint/cmd/golangci-lint@${GOLANGCI_LINT_VERSION}" + GO111MODULE=on go install "github.com/golangci/golangci-lint/cmd/golangci-lint@v${GOLANGCI_LINT_VERSION}"

You're right, "v" should be outside.
Thanks

thank you for fixing my mistake

Signed-off-by: dcoppa <dcoppa@gmail.com>

crenshaw-dev

Thanks!

codecov · 2024-10-07T11:48:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.92%. Comparing base (ae183ad) to head (b6e8973).
Report is 390 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #20264      +/-   ##
==========================================
- Coverage   55.94%   55.92%   -0.03%     
==========================================
  Files         322      322              
  Lines       44673    44673              
==========================================
- Hits        24994    24982      -12     
- Misses      17088    17099      +11     
- Partials     2591     2592       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Fix GOLANGCI_LINT_VERSION Signed-off-by: David Coppa <dcoppa@cocus.com> * chore(deps): bump SonarSource/sonarqube-scan-action from 2.3.0 to 3.0.0 (argoproj#19524) Bumps [SonarSource/sonarqube-scan-action](https://github.com/sonarsource/sonarqube-scan-action) from 2.3.0 to 3.0.0. - [Release notes](https://github.com/sonarsource/sonarqube-scan-action/releases) - [Commits](SonarSource/sonarqube-scan-action@aecaf43...0c0f395) --- updated-dependencies: - dependency-name: SonarSource/sonarqube-scan-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: David Coppa <dcoppa@cocus.com> * Update install-lint-tools.sh Signed-off-by: dcoppa <dcoppa@gmail.com> --------- Signed-off-by: David Coppa <dcoppa@cocus.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dcoppa <dcoppa@gmail.com> Co-authored-by: David Coppa <dcoppa@cocus.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: alnoor <alihamzanoor99@gmail.com>

* Fix GOLANGCI_LINT_VERSION Signed-off-by: David Coppa <dcoppa@cocus.com> * chore(deps): bump SonarSource/sonarqube-scan-action from 2.3.0 to 3.0.0 (argoproj#19524) Bumps [SonarSource/sonarqube-scan-action](https://github.com/sonarsource/sonarqube-scan-action) from 2.3.0 to 3.0.0. - [Release notes](https://github.com/sonarsource/sonarqube-scan-action/releases) - [Commits](SonarSource/sonarqube-scan-action@aecaf43...0c0f395) --- updated-dependencies: - dependency-name: SonarSource/sonarqube-scan-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: David Coppa <dcoppa@cocus.com> * Update install-lint-tools.sh Signed-off-by: dcoppa <dcoppa@gmail.com> --------- Signed-off-by: David Coppa <dcoppa@cocus.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dcoppa <dcoppa@gmail.com> Co-authored-by: David Coppa <dcoppa@cocus.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>

* Fix GOLANGCI_LINT_VERSION Signed-off-by: David Coppa <dcoppa@cocus.com> * chore(deps): bump SonarSource/sonarqube-scan-action from 2.3.0 to 3.0.0 (argoproj#19524) Bumps [SonarSource/sonarqube-scan-action](https://github.com/sonarsource/sonarqube-scan-action) from 2.3.0 to 3.0.0. - [Release notes](https://github.com/sonarsource/sonarqube-scan-action/releases) - [Commits](SonarSource/sonarqube-scan-action@aecaf43...0c0f395) --- updated-dependencies: - dependency-name: SonarSource/sonarqube-scan-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: David Coppa <dcoppa@cocus.com> * Update install-lint-tools.sh Signed-off-by: dcoppa <dcoppa@gmail.com> --------- Signed-off-by: David Coppa <dcoppa@cocus.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dcoppa <dcoppa@gmail.com> Co-authored-by: David Coppa <dcoppa@cocus.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Adrian Aneci <aneci@adobe.com>

dcoppa requested a review from a team as a code owner October 7, 2024 09:38

David Coppa and others added 2 commits October 7, 2024 11:42

Fix GOLANGCI_LINT_VERSION

95f650a

Signed-off-by: David Coppa <dcoppa@cocus.com>

dcoppa force-pushed the master branch from 76dfaa8 to 2aa48d2 Compare October 7, 2024 09:42

dcoppa requested a review from a team as a code owner October 7, 2024 09:42

Merge branch 'master' into master

629192b

dcoppa changed the title ~~Fix GOLANGCI_LINT_VERSION~~ fix: GOLANGCI_LINT_VERSION Oct 7, 2024

ggjulio reviewed Oct 7, 2024

View reviewed changes

Update install-lint-tools.sh

b6e8973

Signed-off-by: dcoppa <dcoppa@gmail.com>

ggjulio approved these changes Oct 7, 2024

View reviewed changes

crenshaw-dev approved these changes Oct 7, 2024

View reviewed changes

crenshaw-dev enabled auto-merge (squash) October 7, 2024 11:15

crenshaw-dev merged commit 345c8a1 into argoproj:master Oct 7, 2024
26 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: GOLANGCI_LINT_VERSION #20264

fix: GOLANGCI_LINT_VERSION #20264

Uh oh!

dcoppa commented Oct 7, 2024

Uh oh!

bunnyshell bot commented Oct 7, 2024 •

edited

Loading

Uh oh!

bunnyshell bot commented Oct 7, 2024 •

edited

Loading

Uh oh!

ggjulio Oct 7, 2024 •

edited

Loading

Uh oh!

dcoppa Oct 7, 2024

Uh oh!

ggjulio Oct 7, 2024 •

edited

Loading

Uh oh!

crenshaw-dev left a comment

Uh oh!

Uh oh!

codecov bot commented Oct 7, 2024 •

edited

Loading

Uh oh!

Uh oh!

fix: GOLANGCI_LINT_VERSION #20264

fix: GOLANGCI_LINT_VERSION #20264

Uh oh!

Conversation

dcoppa commented Oct 7, 2024

Uh oh!

bunnyshell bot commented Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment deleted from Bunnyshell

Uh oh!

bunnyshell bot commented Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment deleted from Bunnyshell

Uh oh!

ggjulio Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dcoppa Oct 7, 2024

Choose a reason for hiding this comment

Uh oh!

ggjulio Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

crenshaw-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

bunnyshell bot commented Oct 7, 2024 •

edited

Loading

bunnyshell bot commented Oct 7, 2024 •

edited

Loading

ggjulio Oct 7, 2024 •

edited

Loading

ggjulio Oct 7, 2024 •

edited

Loading

codecov bot commented Oct 7, 2024 •

edited

Loading