Skip to content

docs: Endpoints not excluded by default (#16023) #20014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2024
Merged

docs: Endpoints not excluded by default (#16023) #20014

merged 1 commit into from
Sep 19, 2024

Conversation

agaudreault
Copy link
Member

Doc did not reflect the code in

argo-cd/util/settings/resources_filter.go

Lines 3 to 11 in 5183b2a

// The core exclusion list are K8s resources that we assume will never be managed by operators,
// and are never child objects of managed resources that need to be presented in the resource tree.
// This list contains high volume and high churn metadata objects which we exclude for performance
// reasons, reducing connections and load to the K8s API servers of managed clusters.
var coreExcludedResources = []FilteredResource{
{APIGroups: []string{"events.k8s.io", "metrics.k8s.io"}},
{APIGroups: []string{""}, Kinds: []string{"Event"}},
{APIGroups: []string{"coordination.k8s.io"}, Kinds: []string{"Lease"}},
}

Closes #16023

@agaudreault
docs: Endpoints not excluded by default
5183b2a 
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault requested review from a team as code owners September 19, 2024 18:54
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 19, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 19, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@agaudreault agaudreault enabled auto-merge (squash) September 19, 2024 18:54
@agaudreault agaudreault merged commit a78594b into argoproj:master Sep 19, 2024
21 of 23 checks passed
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@agaudreault @adriananeci
docs: Endpoints not excluded by default (argoproj#16023) (argoproj#20014
ee8a6ba 
)

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Endpoints not ignored by ArgoCD Application Controller
2 participants
@agaudreault @ishitasequeira