Skip to content

docs: corrected --roleARN to --role-arn as per updated CLI option #20065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2024
Merged

docs: corrected --roleARN to --role-arn as per updated CLI option #20065

merged 1 commit into from
Sep 24, 2024

Conversation

nueavv
Copy link
Member

@nueavv nueavv commented Sep 23, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@nueavv nueavv requested review from a team as code owners September 23, 2024 16:33
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 23, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 23, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@alexmt alexmt merged commit fe67cd5 into argoproj:master Sep 24, 2024
27 checks passed
ratulbasak pushed a commit to ratulbasak/argo-cd that referenced this pull request Sep 25, 2024
@nueavv @ratulbasak
fix: corrected --roleARN to --role-arn as per updated CLI option (arg…
92ba40d 
…oproj#20065)

Signed-off-by: nueavv <nuguni@kakao.com>
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@nueavv @adriananeci
fix: corrected --roleARN to --role-arn as per updated CLI option (arg…
67d0e24 
…oproj#20065)

Signed-off-by: nueavv <nuguni@kakao.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

+1 more reviewer

@morey-tech morey-tech morey-tech approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nueavv @alexmt @morey-tech