Skip to content

Conversation

morey-tech
Copy link
Contributor

@morey-tech morey-tech commented Sep 22, 2024

Supports the changes added in #18388.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@morey-tech morey-tech requested review from a team as code owners September 22, 2024 21:17
Copy link

bunnyshell bot commented Sep 22, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Sep 22, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
@morey-tech morey-tech force-pushed the repo-creds-docs-updates branch from da621c0 to aa8a723 Compare September 22, 2024 21:20
@blakepettersson blakepettersson merged commit 602665f into argoproj:master Sep 22, 2024
22 checks passed
@blakepettersson
Copy link
Member

Thanks @morey-tech !!!

@morey-tech morey-tech deleted the repo-creds-docs-updates branch September 23, 2024 18:15
ratulbasak pushed a commit to ratulbasak/argo-cd that referenced this pull request Sep 25, 2024
* docs: add link to example repo creds yaml

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

* docs: add project to repo creds examples

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

---------

Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
* docs: add link to example repo creds yaml

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

* docs: add project to repo creds examples

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

---------

Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants