Skip to content

chore: Make dev env redis password protected #19863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 17, 2024
Merged

chore: Make dev env redis password protected #19863

merged 15 commits into from
Sep 17, 2024

Conversation

reggie-k
Copy link
Member

@reggie-k reggie-k commented Sep 10, 2024 •
edited
Loading

Closes #19865

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@reggie-k
create pr
91e4f82 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k
create pr
cad3f7a 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k
create pr
4b9770c 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k
Merge branch 'master' of https://github.com/argoproj/argo-cd
b1f6a8d
@reggie-k
Merge branch 'master' of https://github.com/argoproj/argo-cd
1edf63e
@reggie-k
initial
64808b9 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k reggie-k requested review from a team as code owners September 10, 2024 09:33
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 10, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 10, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@reggie-k
initial
a8cfa3c 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k
initial
021417a 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k reggie-k changed the title Make dev env redis password protected chore: Make dev env redis password protected Sep 10, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.83%. Comparing base (20f9719) to head (e796580).
Report is 428 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #19863      +/-   ##
==========================================
+ Coverage   55.80%   55.83%   +0.02%     
==========================================
  Files         320      320              
  Lines       44393    44393              
==========================================
+ Hits        24773    24785      +12     
+ Misses      17056    17044      -12     
  Partials     2564     2564

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nitishfy
nitishfy reviewed Sep 10, 2024
View reviewed changes
nitishfy
nitishfy approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works really well.

I've added a small comment, feel free to add if it is necessary otherwise there is no harm ignoring it either.

nitishfy
nitishfy reviewed Sep 10, 2024
View reviewed changes
nitishfy
nitishfy requested changes Sep 10, 2024
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, thanks!

reggie-k and others added 4 commits September 17, 2024 12:58
@reggie-k @nitishfy
Update hack/start-redis-with-password.sh
9932c19 
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Regina Voloshin <19544836+reggie-k@users.noreply.github.com>
@reggie-k @nitishfy
Update hack/start-redis-with-password.sh
979a1ab 
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Regina Voloshin <19544836+reggie-k@users.noreply.github.com>
@reggie-k
fixed unreachable code
111e484 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k
Merge branch 'master' into make-dev-env-redis-password-protected
e796580
nitishfy
nitishfy approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gdsoumya
gdsoumya approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdsoumya gdsoumya merged commit a8e70e4 into argoproj:master Sep 17, 2024
27 of 28 checks passed
christianh814
christianh814 reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@christianh814 christianh814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@reggie-k reggie-k mentioned this pull request Oct 7, 2024
Closed
7 tasks
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@reggie-k @nitishfy @adriananeci
chore: Make dev env redis password protected (argoproj#19863)
c74fa6c 
* create pr

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>

* create pr

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>

* create pr

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>

* initial

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>

* initial

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>

* initial

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>

* checking Redis is installed locally per Nitish's suggestion

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>

* Update hack/start-redis-with-password.sh

Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Regina Voloshin <19544836+reggie-k@users.noreply.github.com>

* Update hack/start-redis-with-password.sh

Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Regina Voloshin <19544836+reggie-k@users.noreply.github.com>

* fixed unreachable code

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>

---------

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: Regina Voloshin <19544836+reggie-k@users.noreply.github.com>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
@reggie-k reggie-k deleted the make-dev-env-redis-password-protected branch June 15, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdsoumya gdsoumya gdsoumya approved these changes

@nitishfy nitishfy nitishfy approved these changes

+1 more reviewer

@christianh814 christianh814 christianh814 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make dev env redis password protected
4 participants
@reggie-k @christianh814 @gdsoumya @nitishfy