Skip to content

Conversation

pasha-codefresh
Copy link
Member

I think tests break because DST changes, i will take AI to fix it in a better way, for now, I just want to unblock people.

This is example where test is failed

https://github.com/argoproj/argo-cd/runs/4130501990?check_suite_focus=true

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@codecov
Copy link

codecov bot commented Nov 7, 2021

Codecov Report

Merging #7643 (72c2464) into master (0a64781) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7643   +/-   ##
=======================================
  Coverage   41.45%   41.45%           
=======================================
  Files         161      161           
  Lines       21788    21788           
=======================================
  Hits         9033     9033           
  Misses      11484    11484           
  Partials     1271     1271           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a64781...72c2464. Read the comment docs.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @pasha-codefresh !

LGTM.

@jannfis
Copy link
Member

jannfis commented Nov 7, 2021

FYI @ishitasequeira

@jannfis jannfis merged commit 2e84638 into argoproj:master Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants