fix: TestRepository should assume git by default #7630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Codecov Report
@@ Coverage Diff @@
## master #7630 +/- ##
==========================================
+ Coverage 41.44% 41.45% +0.01%
==========================================
Files 161 161
Lines 21787 21788 +1
==========================================
+ Hits 9030 9033 +3
+ Misses 11487 11484 -3
- Partials 1270 1271 +1
Continue to review full report at Codecov.
|
alexmt
approved these changes
Nov 5, 2021
| @@ -249,7 +249,7 @@ func (m *TestRepositoryRequest) GetRepo() *v1alpha1.Repository { | |||
| return nil | |||
| } | |||
|
|
|||
| // TestRepositoryRequest is a query to test repository is valid or not and has valid access. | |||
| // TestRepositoryResponse represents the TestRepository response | |||
There was a problem hiding this comment.
The repository.pb.go is autogenerated file. Comment shuold be updated in
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com
Fixes #7369
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: