Skip to content

docs: Update CI troubleshooting guide on build steps #7639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2021
Merged

docs: Update CI troubleshooting guide on build steps #7639

merged 1 commit into from
Nov 8, 2021

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Nov 7, 2021 •
edited
Loading

The existing guide refers to outdated use of Gopkg.lock and dep. Updated this to reflect what's in ci-build.yaml.

Signed-off-by: Yuan Tang terrytangyuan@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@terrytangyuan
docs: Update CI troubleshooting guide on build steps
ae6bd88 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@codecov
Copy link

codecov bot commented Nov 7, 2021

Codecov Report

Merging #7639 (ae6bd88) into master (0a64781) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7639   +/-   ##
=======================================
  Coverage   41.45%   41.45%           
=======================================
  Files         161      161           
  Lines       21788    21788           
=======================================
  Hits         9033     9033           
  Misses      11484    11484           
  Partials     1271     1271
Impacted Files Coverage Δ
util/settings/settings.go 46.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a64781...ae6bd88. Read the comment docs.

mayzhang2000
mayzhang2000 approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit a3517d5 into argoproj:master Nov 8, 2021
@terrytangyuan terrytangyuan deleted the rm-gopkg branch November 8, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayzhang2000 mayzhang2000 mayzhang2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terrytangyuan @mayzhang2000 @alexmt