Skip to content

docs: Add -s to sign off empty commits that retriggers CI #7628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2021
Merged

docs: Add -s to sign off empty commits that retriggers CI #7628

merged 1 commit into from
Nov 5, 2021

Conversation

terrytangyuan
Copy link
Member

This will be more friendly to new contributors (often the ones who read this file to help debug CI failures). Otherwise git commit -s --amend or rebase is needed for DCO check when CI is passing.

Signed-off-by: Yuan Tang terrytangyuan@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@terrytangyuan
docs: Add -s to sign off empty commits that retriggers CI
4c52006 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@codecov
Copy link

codecov bot commented Nov 5, 2021 •
edited
Loading

Codecov Report

Merging #7628 (4c52006) into master (b0278c4) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7628   +/-   ##
=======================================
  Coverage   41.44%   41.45%           
=======================================
  Files         161      161           
  Lines       21787    21787           
=======================================
+ Hits         9030     9032    +2     
+ Misses      11487    11486    -1     
+ Partials     1270     1269    -1
Impacted Files Coverage Δ
util/settings/settings.go 47.09% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0278c4...4c52006. Read the comment docs.

jannfis
jannfis approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

LGTM.

@jessesuen jessesuen merged commit 43a29e6 into argoproj:master Nov 5, 2021
@terrytangyuan terrytangyuan deleted the missing-s branch November 5, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis approved these changes

@jessesuen jessesuen jessesuen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terrytangyuan @jannfis @jessesuen