Skip to content

Conversation

plakyda-codefresh
Copy link
Contributor

@plakyda-codefresh plakyda-codefresh commented Nov 2, 2021

Closes #7596
Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@plakyda-codefresh plakyda-codefresh changed the title Feat remove cluster confirm feat: remove cluster confirmation Nov 2, 2021
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #7602 (1eb7423) into master (8b10b64) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7602      +/-   ##
==========================================
- Coverage   41.39%   41.39%   -0.01%     
==========================================
  Files         161      161              
  Lines       21687    21686       -1     
==========================================
- Hits         8977     8976       -1     
  Misses      11445    11445              
  Partials     1265     1265              
Impacted Files Coverage Δ
pkg/apis/application/v1alpha1/types.go 57.27% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b10b64...1eb7423. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexmt alexmt merged commit 6036e9b into argoproj:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a confirmation dialog for deleting clusters in the UI
4 participants