Skip to content

docs: remove mention of ksonnet in basics #7567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2021
Merged

docs: remove mention of ksonnet in basics #7567

merged 1 commit into from
Oct 29, 2021

Conversation

NillsF
Copy link
Contributor

@NillsF NillsF commented Oct 28, 2021 •
edited
Loading

As announced here, the ksonnet project is being sunset. I suggest removing the link from the basics documentation page.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@NillsF
docs: remove mention of ksonnet in basics
5d03035 
Signed-off-by: Nills Franssens <nills.franssens@gmail.com>
alexmt
alexmt approved these changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. We have to keep integration with KSonnet since there are users who need it, but we should not advertise ksonnet and confuse new users.

@codecov
Copy link

codecov bot commented Oct 28, 2021 •
edited
Loading

Codecov Report

Merging #7567 (5d03035) into master (7ced59f) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7567   +/-   ##
=======================================
  Coverage   41.40%   41.41%           
=======================================
  Files         161      161           
  Lines       21622    21622           
=======================================
+ Hits         8952     8954    +2     
+ Misses      11408    11407    -1     
+ Partials     1262     1261    -1
Impacted Files Coverage Δ
util/settings/settings.go 47.09% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ced59f...5d03035. Read the comment docs.

@alexmt alexmt merged commit 5b91475 into argoproj:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NillsF @alexmt