Skip to content

docs: Adding Image Updater video #7547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2021
Merged

docs: Adding Image Updater video #7547

merged 1 commit into from
Oct 25, 2021

Conversation

vfarcic
Copy link
Contributor

@vfarcic vfarcic commented Oct 25, 2021

Added a video to the README

@vfarcic
Image Updater
eb9c803 
Signed-off-by: Viktor Farcic <viktor@farcic.com>
@codecov
Copy link

codecov bot commented Oct 25, 2021 •
edited
Loading

Codecov Report

Merging #7547 (eb9c803) into master (1804d77) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7547   +/-   ##
=======================================
  Coverage   41.38%   41.38%           
=======================================
  Files         161      161           
  Lines       21619    21619           
=======================================
  Hits         8948     8948           
  Misses      11408    11408           
  Partials     1263     1263

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1804d77...eb9c803. Read the comment docs.

jannfis
jannfis approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @vfarcic and congratulations on a great video!

Also thanks for the constructive feedback at the end, much appreciated. Ability to create PRs is a much demanded feature, and I'm pretty sure that this feature will be implemented sooner or later. And the idea to modify Application stored in Git instead of application manifests is actually a great idea. Feel free to open an enhancement request :)

@jannfis jannfis merged commit 07b8a1f into argoproj:master Oct 25, 2021
@vfarcic
Copy link
Contributor Author

vfarcic commented Oct 26, 2021

Opened argoproj-labs/argocd-image-updater#282.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vfarcic @jannfis