Skip to content

feat: support pprof endpoints #7533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2021
Merged

feat: support pprof endpoints #7533

merged 1 commit into from
Nov 1, 2021

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Oct 23, 2021 •
edited
Loading

Signed-off-by: Ben Ye ben.ye@bytedance.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

This pr adds pprof support to the metrics port. This can be used for easier debugging and performance profiling.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Oct 23, 2021 •
edited
Loading

Codecov Report

Merging #7533 (2f35bc8) into master (7fe8e5f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7533   +/-   ##
=======================================
  Coverage   41.38%   41.39%           
=======================================
  Files         161      161           
  Lines       21618    21620    +2     
=======================================
+ Hits         8947     8949    +2     
  Misses      11408    11408           
  Partials     1263     1263
Impacted Files Coverage Δ
controller/metrics/metrics.go 80.00% <100.00%> (+0.13%) ⬆️
util/settings/settings.go 46.83% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe8e5f...2f35bc8. Read the comment docs.

@yeya24 yeya24 force-pushed the support-pprof-endpoints branch 2 times, most recently from e8d9223 to e7781b8 Compare October 25, 2021 04:17
feat: support pprof endpoints
2f35bc8 
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
@yeya24 yeya24 force-pushed the support-pprof-endpoints branch from e7781b8 to 2f35bc8 Compare October 25, 2021 04:49
@yeya24
Copy link
Contributor Author

yeya24 commented Oct 29, 2021

Is this pr good to go? @alexmt

alexmt
alexmt approved these changes Nov 1, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yeya24 ! It looks good.

@alexmt alexmt merged commit 49b7152 into argoproj:master Nov 1, 2021
@yeya24 yeya24 deleted the support-pprof-endpoints branch November 1, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeya24 @alexmt