Skip to content

fix: mkdocs doesnt work with 3.10.0 python #7518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 21, 2021
Merged

fix: mkdocs doesnt work with 3.10.0 python #7518

merged 6 commits into from
Oct 21, 2021

Conversation

pasha-codefresh
Copy link
Member

@pasha-codefresh pasha-codefresh commented Oct 21, 2021 •
edited
Loading

Python just pushed new version 3.10.0 that cause mkdocs be broken. For unblock contributors I suggest use fixed version until understand and fix an issue

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.10.0/x64/bin/mkdocs", line 5, in <module>
    from mkdocs.__main__ import cli
  File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/site-packages/mkdocs/__main__.py", line 16, in <module>
    from mkdocs import config                                 # noqa: E402
  File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/site-packages/mkdocs/config/__init__.py", line 2, in <module>
    from mkdocs.config.defaults import DEFAULT_SCHEMA
  File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/site-packages/mkdocs/config/defaults.py", line 1, in <module>
    from mkdocs.config import config_options
  File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/site-packages/mkdocs/config/config_options.py", line 2, in <module>
    from collections import Sequence, namedtuple
ImportError: cannot import name 'Sequence' from 'collections' (/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/collections/__init__.py)

https://github.com/argoproj/argo-cd/runs/3968380676?check_suite_focus=true
https://github.com/argoproj/argo-cd/runs/3968402046?check_suite_focus=true

@pasha-codefresh
group diff should set resource id use new interface
c4acd8f 
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@pasha-codefresh
fix mkdocs
b61240a 
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@pasha-codefresh
Merge branch 'master' into fix-mkdocs
6648558
alexmt
alexmt approved these changes Oct 21, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 21, 2021 •
edited
Loading

Codecov Report

Merging #7518 (3416332) into master (d6d620e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7518   +/-   ##
=======================================
  Coverage   41.38%   41.38%           
=======================================
  Files         161      161           
  Lines       21618    21618           
=======================================
  Hits         8947     8947           
  Misses      11408    11408           
  Partials     1263     1263
Impacted Files Coverage Δ
util/settings/settings.go 46.77% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d620e...3416332. Read the comment docs.

@pasha-codefresh
empty
83a226b 
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@pasha-codefresh
Merge remote-tracking branch 'origin/fix-mkdocs' into fix-mkdocs
0ce55f4
@pasha-codefresh
empty
3416332 
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@alexmt alexmt merged commit b8510f3 into argoproj:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pasha-codefresh @alexmt