Skip to content

fix: Fix Color Support in Logs #7476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2021
Merged

fix: Fix Color Support in Logs #7476

merged 1 commit into from
Oct 20, 2021

Conversation

nekia
Copy link
Contributor

@nekia nekia commented Oct 19, 2021 •
edited
Loading

Signed-off-by: Atsushi Neki nekiaiken@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Fixes #5990

@nekia nekia changed the title fix: Fix Color Support in Logs fix: Fix Color Support in Logs #5990 Oct 19, 2021
@nekia nekia changed the title fix: Fix Color Support in Logs #5990 fix: Fix Color Support in Logs Oct 19, 2021
@alexmt
Copy link
Collaborator

alexmt commented Oct 19, 2021

Thank you @nekia ! You can use yarn lint --fix --project . to fix formatting issues.

@nekia
fix: Fix Color Support in Logs
efe695f 
Signed-off-by: Atsushi Neki <nekiaiken@gmail.com>
@nekia nekia force-pushed the fix-color-support-in-logs-2 branch from 0f56c6c to efe695f Compare October 20, 2021 08:27
@nekia
Copy link
Contributor Author

nekia commented Oct 20, 2021

FYR: Added the screenshot fixed log viewer.
Screenshot from 2021-10-20 19-33-38

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #7476 (efe695f) into master (374965a) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7476      +/-   ##
==========================================
- Coverage   41.37%   41.35%   -0.03%     
==========================================
  Files         161      161              
  Lines       21595    21606      +11     
==========================================
  Hits         8936     8936              
- Misses      11397    11407      +10     
- Partials     1262     1263       +1
Impacted Files Coverage Δ
reposerver/repository/repository.go 60.64% <0.00%> (-0.31%) ⬇️
controller/appcontroller.go 53.14% <0.00%> (-0.17%) ⬇️
cmd/argocd/commands/login.go 2.29% <0.00%> (-0.03%) ⬇️
cmd/argocd/commands/relogin.go 0.00% <0.00%> (ø)
pkg/apis/application/v1alpha1/types.go 57.51% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 374965a...efe695f. Read the comment docs.

alexmt
alexmt approved these changes Oct 20, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Awesome contribution

@alexmt alexmt merged commit d460f84 into argoproj:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color Support in Logs broken with 2.0
3 participants
@nekia @alexmt @jannfis