Skip to content

fix: docker image for ui-test #7461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2021
Merged

fix: docker image for ui-test #7461

merged 3 commits into from
Oct 20, 2021

Conversation

mayzhang2000
Copy link
Contributor

@mayzhang2000 mayzhang2000 commented Oct 15, 2021 •
edited
Loading

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

fixes: #6847

@mayzhang2000
fix: initial draft of dockerfile
0b04b4f 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fix: initial draft of dockerfile
2282833 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@codecov
Copy link

codecov bot commented Oct 15, 2021 •
edited
Loading

Codecov Report

Merging #7461 (3c91e39) into master (b073621) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7461      +/-   ##
==========================================
+ Coverage   41.24%   41.37%   +0.12%     
==========================================
  Files         161      161              
  Lines       21525    21593      +68     
==========================================
+ Hits         8878     8934      +56     
- Misses      11384    11397      +13     
+ Partials     1263     1262       -1
Impacted Files Coverage Δ
util/env/env.go 61.53% <0.00%> (-22.68%) ⬇️
server/cluster/cluster.go 22.51% <0.00%> (-0.36%) ⬇️
server/application/application.go 32.29% <0.00%> (-0.04%) ⬇️
controller/appcontroller.go 53.30% <0.00%> (ø)
cmd/argocd/commands/project.go 0.00% <0.00%> (ø)
util/git/client.go 44.74% <0.00%> (+0.18%) ⬆️
util/helm/helm.go 60.81% <0.00%> (+0.53%) ⬆️
controller/metrics/metrics.go 79.86% <0.00%> (+3.43%) ⬆️
util/rbac/rbac.go 76.39% <0.00%> (+5.53%) ⬆️
controller/metrics/clustercollector.go 54.16% <0.00%> (+54.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b073621...3c91e39. Read the comment docs.

@wtam2018
Copy link
Contributor

Do we need to install yarn in the image?

alexmt
alexmt requested changes Oct 18, 2021
View reviewed changes
@mayzhang2000
fix: use yarn install
3c91e39 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
Copy link
Contributor Author

Thank you @alexmt and @wtam2018 for your review!

alexmt
alexmt approved these changes Oct 20, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 046840d into argoproj:master Oct 20, 2021
@mayzhang2000 mayzhang2000 added hacktoberfest hacktoberfest-accepted Accepted Hacktoberfest contribution labels Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted Accepted Hacktoberfest contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dockerize UI e2e tests dependencies
3 participants
@mayzhang2000 @wtam2018 @alexmt