Skip to content

Conversation

jmastr
Copy link
Contributor

@jmastr jmastr commented Oct 13, 2021

Pass the global flag to the argocdclient.

Closes #7422

* fix: #7422

Signed-off-by: Julian Strobl <julian.strobl@telekom.de>
@jmastr jmastr changed the title Fix client certificate ignored during re(login) Fix client certificate ignored during (re)login Oct 13, 2021
@chetan-rns
Copy link
Member

This will close #7036 as well. @alexmt Could you please approve the workflow checks?

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #7423 (0163402) into master (d7d8fe3) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7423      +/-   ##
==========================================
- Coverage   41.32%   41.31%   -0.01%     
==========================================
  Files         161      161              
  Lines       21590    21594       +4     
==========================================
  Hits         8921     8921              
- Misses      11408    11412       +4     
  Partials     1261     1261              
Impacted Files Coverage Δ
cmd/argocd/commands/login.go 2.29% <0.00%> (-0.03%) ⬇️
cmd/argocd/commands/relogin.go 0.00% <0.00%> (ø)
util/settings/settings.go 46.77% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7d8fe3...0163402. Read the comment docs.

@jmastr
Copy link
Contributor Author

jmastr commented Oct 19, 2021

@chetan-rns are we good to merge this? do you have write access?

@alexmt alexmt merged commit 00874af into argoproj:master Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client Certificate ignored during (re)login
3 participants