Skip to content

docs: Append echo to kubectl get secrets command in getting_started.md. Closes #7355 #7403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2021
Merged

docs: Append echo to kubectl get secrets command in getting_started.md. Closes #7355 #7403

merged 1 commit into from
Oct 11, 2021

Conversation

mustafa89
Copy link
Contributor

Change to docs:
Add echo to the end of the kubectl command so that '%' new line character is not printed at the end of the secret. Closes [ISSUE #7355]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@mustafa89
docs: Append echo to kubectl in getting_started.md
f91d677 
Add echo to the end of the kubectl command to fetch initial admin secrets so that '%' new line character is not printed at the end of the secret.

Signed-off-by: mustafa89 <mustafa.mujahid@outlook.com>
@mustafa89 mustafa89 force-pushed the mustafa89/docs-update branch from 78caf5f to f91d677 Compare October 11, 2021 11:57
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #7403 (f91d677) into master (363e1d2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7403   +/-   ##
=======================================
  Coverage   41.33%   41.33%           
=======================================
  Files         161      161           
  Lines       21581    21581           
=======================================
  Hits         8920     8920           
  Misses      11400    11400           
  Partials     1261     1261

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 363e1d2...f91d677. Read the comment docs.

alexmt
alexmt approved these changes Oct 11, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think just adding echo into the command is better than documenting it.

@jannfis , are you ok with it? Want to double-check since you choose not to add echo initially.

@jannfis
Copy link
Member

jannfis commented Oct 11, 2021

I'm fine with it 👍

@jannfis jannfis merged commit 5faea8f into argoproj:master Oct 11, 2021
@chetan-rns chetan-rns mentioned this pull request Oct 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mustafa89 @jannfis @alexmt