Skip to content

Conversation

chetan-rns
Copy link
Member

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

The PR introduces the following changes:

  1. Upgrade chromedriver dependency to work with latest versions of Chrome
  2. Fix the failing UI tests in the folder ui-test. The tests were failing with the error:
About to create application
Trace: Test failed  Error: TimeoutError: Waiting until element is visible
Wait timed out after 60035ms
    at ApplicationCreatePanel.<anonymous> (/home/cbanavik/go/src/github.com/argoproj/argo-cd/ui-test/out/application-create-panel/application-create-panel.js:141:23)
    at Generator.throw (<anonymous>)
    at rejected (/home/cbanavik/go/src/github.com/argoproj/argo-cd/ui-test/out/application-create-panel/application-create-panel.js:25:65)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at /home/cbanavik/go/src/github.com/argoproj/argo-cd/ui-test/out/test001.js:55:23
    at Generator.throw (<anonymous>)
    at rejected (/home/cbanavik/go/src/github.com/argoproj/argo-cd/ui-test/out/test001.js:6:65)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
Done in 64.50s.

Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #7392 (b6177c0) into master (df5cce8) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7392      +/-   ##
==========================================
+ Coverage   41.17%   41.24%   +0.06%     
==========================================
  Files         161      161              
  Lines       21638    21508     -130     
==========================================
- Hits         8910     8871      -39     
+ Misses      11457    11379      -78     
+ Partials     1271     1258      -13     
Impacted Files Coverage Δ
server/application/application.go 32.32% <0.00%> (-0.48%) ⬇️
server/application/logs.go 85.71% <0.00%> (+2.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5cce8...b6177c0. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing it. LGTM!

@alexmt alexmt merged commit 1bc231d into argoproj:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants