feat: Cluster name as part of sync #7394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
alexmt
requested changes
Oct 8, 2021
| @@ -354,7 +354,7 @@ func (proj AppProject) IsSourcePermitted(src ApplicationSource) bool { | |||
| // IsDestinationPermitted validates if the provided application's destination is one of the allowed destinations for the project | |||
| func (proj AppProject) IsDestinationPermitted(dst ApplicationDestination) bool { | |||
| for _, item := range proj.Spec.Destinations { | |||
| if globMatch(item.Server, dst.Server) && globMatch(item.Namespace, dst.Namespace) { | |||
| if (globMatch(item.Server, dst.Server) || globMatch(item.Server, dst.Name)) && globMatch(item.Namespace, dst.Namespace) { | |||
There was a problem hiding this comment.
The cluster name should be compared with the name in the destination. I think this should work:
Suggested change
| if (globMatch(item.Server, dst.Server) || globMatch(item.Server, dst.Name)) && globMatch(item.Namespace, dst.Namespace) { | |
| if (globMatch(item.Server, dst.Server) || globMatch(item.Name, dst.Name)) && globMatch(item.Namespace, dst.Namespace) { |
Signed-off-by: pashavictorovich <pavel@codefresh.io>
…to cluster-name-as-part-of-sync
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Codecov Report
@@ Coverage Diff @@
## master #7394 +/- ##
==========================================
+ Coverage 41.24% 41.33% +0.09%
==========================================
Files 161 161
Lines 21525 21583 +58
==========================================
+ Hits 8878 8922 +44
- Misses 11384 11400 +16
+ Partials 1263 1261 -2
Continue to review full report at Codecov.
|
This was referenced Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7198