fix: fix parameter name when the value is a list (#7360) #7362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Assel Meher <asselmeher@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #7362 +/- ##
==========================================
+ Coverage 41.12% 41.25% +0.13%
==========================================
Files 158 161 +3
Lines 21365 21509 +144
==========================================
+ Hits 8786 8874 +88
- Misses 11313 11378 +65
+ Partials 1266 1257 -9
Continue to review full report at Codecov.
|
mayzhang2000
approved these changes
Oct 12, 2021
util/helm/helm_test.go
Outdated
| @@ -192,7 +192,7 @@ func Test_flatVals(t *testing.T) { | |||
| t.Run("Array", func(t *testing.T) { | |||
| output := map[string]string{} | |||
|
|
|||
| flatVals(map[string]interface{}{"foo": []interface{}{"bar"}}, output) | |||
| flatVals(map[string]interface{}{"foo": []interface{}{"bar", "baz"}}, output) | |||
|
|
|||
| assert.Equal(t, map[string]string{"foo[0]": "bar"}, output) | |||
There was a problem hiding this comment.
Should the expected output be map[string]string{"foo[0]": "bar", "foo[1]": "baz"}?
| @@ -171,8 +171,9 @@ func flatVals(input interface{}, output map[string]string, prefixes ...string) { | |||
| flatVals(v, output, append(prefixes, k)...) | |||
| } | |||
| case []interface{}: | |||
| p := append([]string(nil), prefixes...) | |||
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7360
Checklist: