chore: More informative error message when redirect URL is invalid #7331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #7331 +/- ##
=======================================
Coverage 41.17% 41.17%
=======================================
Files 161 161
Lines 21612 21612
=======================================
Hits 8899 8899
Misses 11446 11446
Partials 1267 1267
Continue to review full report at Codecov.
|
alexmt
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
LGTM. Thank you @terrytangyuan ! The new error message is much better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across the error
Invalid return_urlwhen developing locally and I had to dig the codebase and issues to figure out the root cause.Signed-off-by: Yuan Tang terrytangyuan@gmail.com