chore: lua script for pause/resume action for Deployments #7293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ishitasequeira <isequeir@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #7293 +/- ##
=======================================
Coverage 41.10% 41.10%
=======================================
Files 160 160
Lines 21505 21505
=======================================
Hits 8840 8840
Misses 11399 11399
Partials 1266 1266 Continue to review full report at Codecov.
|
jessesuen
reviewed
Sep 24, 2021
| {"apiVersion":"apps/v1","kind":"Deployment","metadata":{"annotations":{"deployment.kubernetes.io/revision":"1"},"creationTimestamp":"2019-09-12T01:33:53Z","generation":1,"name":"nginx-deploy","namespace":"default","resourceVersion":"6897444","selfLink":"/apis/apps/v1/namespaces/default/deployments/nginx-deploy","uid":"61689d6d-d4fd-11e9-9e69-42010aa8005f"},"spec":{"progressDeadlineSeconds":600,"replicas":3,"revisionHistoryLimit":10,"selector":{"matchLabels":{"app":"nginx"}},"strategy":{"rollingUpdate":{"maxSurge":"25%","maxUnavailable":"25%"},"type":"RollingUpdate"},"template":{"metadata":{"labels":{"app":"nginx"}},"spec":{"containers":[{"image":"nginx:latest","imagePullPolicy":"Always","name":"nginx","resources":{},"terminationMessagePath":"/dev/termination-log","terminationMessagePolicy":"File"}],"dnsPolicy":"ClusterFirst","restartPolicy":"Always","schedulerName":"default-scheduler","securityContext":{},"terminationGracePeriodSeconds":30}}},"status":{"availableReplicas":2,"conditions":[{"lastTransitionTime":"2019-09-12T01:33:53Z","lastUpdateTime":"2019-09-12T01:33:53Z","message":"Deployment does not have minimum availability.","reason":"MinimumReplicasUnavailable","status":"False","type":"Available"},{"lastTransitionTime":"2019-09-12T01:33:53Z","lastUpdateTime":"2019-09-12T01:34:05Z","message":"ReplicaSet \"nginx-deploy-9cb4784bd\" is progressing.","reason":"ReplicaSetUpdated","status":"True","type":"Progressing"}],"observedGeneration":1,"readyReplicas":2,"replicas":3,"unavailableReplicas":1,"updatedReplicas":3}} | ||
| creationTimestamp: "2021-09-21T22:35:20Z" | ||
| generation: 2 | ||
| managedFields: |
There was a problem hiding this comment.
Could we remove managedFields and kubectl.kubernetes.io/last-applied-configuration from the test yaml?
There was a problem hiding this comment.
Thanks for the review @jessesuen. I have made the required changes.
Signed-off-by: ishitasequeira <isequeir@redhat.com>
jessesuen
approved these changes
Sep 30, 2021
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7250
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Signed off by Ishita Sequeira