fix: add url check and wrapping for commit msg field #7218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7218 +/- ##
=======================================
Coverage 41.17% 41.17%
=======================================
Files 161 161
Lines 21612 21612
=======================================
Hits 8899 8899
Misses 11446 11446
Partials 1267 1267
Continue to review full report at Codecov.
|
alexmt
requested changes
Sep 29, 2021
| @@ -146,6 +146,18 @@ export class ApplicationDetails extends React.Component<RouteComponentProps<{nam | |||
| return this.filterTreeNode(resNode, treeFilter); | |||
| }); | |||
|
|
|||
| const URL_REGEX = /https?:\/\/(www\.)?[-a-zA-Z0-9@:%._\+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_\+.~#?&//=]*)/; | |||
There was a problem hiding this comment.
Nitpick: We already have URL regex defined in application-summary.tsx:
Can you please move it to https://github.com/argoproj/argo-cd/blob/master/ui/src/app/applications/components/utils.tsx and re-use in both application-summary.tsx and application-details.tsx
Signed-off-by: saumeya <saumeyakatyal@gmail.com>
6fa9fa5 to
f1a381d
Compare
lint check Signed-off-by: saumeya <saumeyakatyal@gmail.com>
f1a381d to
4f69807
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: saumeya saumeyakatyal@gmail.com
closes #7158
Checklist: