Feat: cmp server #6585
Merged
Feat: cmp server #6585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
…rver-may2 � Conflicts: � go.mod � go.sum � manifests/base/config/kustomization.yaml � manifests/ha/install.yaml � manifests/ha/namespace-install.yaml � manifests/install.yaml � manifests/namespace-install.yaml � reposerver/repository/repository.go
added e2e test cases Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Codecov Report
@@ Coverage Diff @@
## master #6585 +/- ##
==========================================
- Coverage 41.46% 41.32% -0.15%
==========================================
Files 161 163 +2
Lines 21726 21954 +228
==========================================
+ Hits 9009 9072 +63
- Misses 11450 11597 +147
- Partials 1267 1285 +18
Continue to review full report at Codecov.
|
Signed-off-by: May Zhang <may_zhang@intuit.com>
mayzhang2000
commented
Jul 1, 2021
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
…rver-may3 � Conflicts: � Makefile � manifests/base/repo-server/argocd-repo-server-deployment.yaml � manifests/ha/install.yaml � manifests/ha/namespace-install.yaml � manifests/install.yaml � manifests/namespace-install.yaml � test/e2e/fixture/fixture.go � util/kube/kube.go
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
|
@jopit Please review |
|
@harikrongali will do. I'm on vacation Mon, Tues and Wed next week, so the review likely won't be complete until after. |
|
I'm still in the process of reviewing this PR, it's taking me longer than I thought. |
…rver-may4 � Conflicts: � docs/user-guide/config-management-plugins.md � reposerver/repository/repository.go
…rver-may8 � Conflicts: � Procfile � common/common.go � go.mod
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
…nstants. Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
… create an app with plugin. Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
alexmt
requested changes
Nov 3, 2021
Remove calling ValidatePluginConfig during manifest generation. Signed-off-by: May Zhang <may_zhang@intuit.com>
use json tag for PliginConfig struct. Signed-off-by: May Zhang <may_zhang@intuit.com>
…step since it should be auto-detect. Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
avoid adding new CMP app source type
Signed-off-by: May Zhang <may_zhang@intuit.com>
alexmt
requested changes
Nov 8, 2021
alexmt
approved these changes
Nov 8, 2021
This was referenced Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
This is based on https://github.com/argoproj/argo-cd/pull/6265/files
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: