Skip to content

Unnecessary secretToCluster unmarshalling during Sync time #7531

@yeya24

Description

@yeya24

If you are trying to resolve an environment-specific issue or have a one-off question about the edge case that does not require a feature then please consider asking a question in argocd slack channel.

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

In https://github.com/argoproj/argo-cd/blob/master/util/argo/argo.go#L612, getDestinationServer is called but you can see from the profiles, secretToCluster function gets called and it takes a long time doing unmarshalling. This is unnecessary because we only need to get the destination server address and it is no need to unmarshall the secret in this step.

image

Version

v2.1.0

Logs

Paste any relevant application logs here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions