-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Closed
Closed
Copy link
Labels
bugSomething isn't workingSomething isn't workingcomponent:application-setsBulk application management relatedBulk application management relatedregressionBug is a regression, should be handled with high priorityBug is a regression, should be handled with high priorityversion:3.1
Description
Checklist:
- I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
- I've included steps to reproduce the bug.
- I've pasted the output of
argocd version
.
Describe the bug
An AppSet with PullRequest and an AppSet with SCM generator suddenly require tokenRef
for GitHub, this looks unintended and is caused by this commit:
9b17495bc2fe7c6f07ed5ac5cc154b3ae9027be9
To Reproduce
Use a SCM generator and a PullRequest generator for GitHub from the official docs without secretRef
and 401 will be received.
Expected behavior
It is optional to use secretRef
and should work without.
Screenshots
Version
Paste the output from `argocd version` here.
Logs
Paste any relevant application logs here.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingcomponent:application-setsBulk application management relatedBulk application management relatedregressionBug is a regression, should be handled with high priorityBug is a regression, should be handled with high priorityversion:3.1