Skip to content

refactor: Use KIND to run integration tests #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2020
Merged

refactor: Use KIND to run integration tests #77

merged 3 commits into from
Jun 26, 2020

Conversation

danielpacak
Copy link
Contributor

@danielpacak danielpacak commented Jun 25, 2020 •
edited
Loading

The main changes:

  • Use KinD to spawn a Kubernetes cluster in our CI for integration tests. Previously it was Rancher K3S run with Docker Compose
  • Label [Cluster]Roles and [Cluster]RoleBindings with "app.kubernetes.io/name=who-can" to distinguish them from RBAC defaults in KinD. This will allow us to eventually have more reliable asserts in the integration tests.

Signed-off-by: Daniel Pacak pacak.daniel@gmail.com

@codecov
Copy link

codecov bot commented Jun 25, 2020 •
edited
Loading

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   70.80%   70.80%           
=======================================
  Files           5        5           
  Lines         387      387           
=======================================
  Hits          274      274           
  Misses         98       98           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a0ee9...144f495. Read the comment docs.

@danielpacak danielpacak marked this pull request as ready for review June 26, 2020 09:54
@danielpacak
refactor: Use KIND to run integration tests
14d5b1a 
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@danielpacak danielpacak requested a review from lizrice June 26, 2020 10:46
danielpacak
danielpacak commented Jun 26, 2020
View reviewed changes
danielpacak
danielpacak commented Jun 26, 2020
View reviewed changes
danielpacak
danielpacak commented Jun 26, 2020
View reviewed changes
danielpacak
danielpacak commented Jun 26, 2020
View reviewed changes
lizrice
lizrice approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! (two tiny nits about comments, sorry!)

@danielpacak
apply pr comments
74aeae4 
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@danielpacak
set KUBECONFIG for release build
144f495 
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@danielpacak danielpacak merged commit 36b4791 into aquasecurity:master Jun 26, 2020
@danielpacak danielpacak deleted the refactor_it branch June 26, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@lizrice lizrice lizrice approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielpacak @lizrice