fixes issue #70 removed glog with k8s.io/klog #71
Conversation
There was a problem hiding this comment.
Hi @thanasisk and thank you for the PR! I just tried it out and I got the following error:
./kubectl-who-can get pod --v 6
Error: unknown flag: --v
I think that glog registered the --v flag implicitly in the init block, whereas for klog we have to register it explicitly. Also remember to flush logs in the defer statement:
func main() {
defer klog.Flush()
initFlags()
root, err := cmd.NewWhoCanCommand(clioptions.IOStreams{In: os.Stdin, Out: os.Stdout, ErrOut: os.Stderr})
// ...
}
func initFlags() {
klog.InitFlags(nil)
pflag.CommandLine.AddGoFlagSet(flag.CommandLine)
// Hide all klog flags except for -v
flag.CommandLine.VisitAll(func(f *flag.Flag) {
if f.Name != "v" {
pflag.Lookup(f.Name).Hidden = true
}
})
}Please make sure to preserve the global flags:
./kubectl-who-can -h
Flags:
...
-v, --v Level number for the log level verbosity
--vmodule moduleSpec comma-separated list of pattern=N settings for file-filtered logging
|
thanks will have a look |
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
=======================================
Coverage 70.80% 70.80%
=======================================
Files 5 5
Lines 387 387
=======================================
Hits 274 274
Misses 98 98
Partials 15 15
Continue to review full report at Codecov.
|
Thank you for taking care of it and promptly addressing my comments ! |
addresses #70