fix: Validate use verb for PodSecurityPolicies #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: #63 Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=========================================
+ Coverage 70.64% 70.8% +0.15%
=========================================
Files 5 5
Lines 385 387 +2
=========================================
+ Hits 272 274 +2
Misses 98 98
Partials 15 15
Continue to review full report at Codecov.
|
knqyf263
approved these changes
Feb 20, 2020
| @@ -143,6 +143,9 @@ func (rv *resourceResolver) isVerbSupportedBy(verb string, resource apismeta.API | |||
| if verb == rbac.VerbAll { | |||
| return true | |||
| } | |||
| if resource.Name == "podsecuritypolicies" && verb == "use" { | |||
There was a problem hiding this comment.
nit: If we support any other special verbs in the future, we can write this like the following.
specials = []schema.XXX{
{
Group: "extensions",
Resource: "podsecuritypolicies",
Verb: "use",
},
}
for _, s := range specials {
if resource.Name == s.Resource && verb == s.Verb {
return true
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #63