Allow cmd package to be used as Golang module #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a number of changes to enable the `WhoCan` type to be used in external projects. The `WhoCan` type is exported, and functions are introduced to allow instances of `WhoCan` and `Action` to be created. It also modifies the `Check` function to no longer call `output` to display the results. Instead, `Check` returns the role bindings that enable an action to be performed. The call to `output` now takes place in the run function for the command. Overall, this results in no functional changes to the `kubectl-who-can` program, but allows it to be imported and used from other projects. Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 74.8% 72.29% -2.52%
==========================================
Files 5 5
Lines 381 397 +16
==========================================
+ Hits 285 287 +2
- Misses 84 95 +11
- Partials 12 15 +3
Continue to review full report at Codecov.
|
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
danielpacak
approved these changes
Feb 16, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a number of changes to enable the
WhoCantype to beused in external projects. The
WhoCantype is exported, and functionsare introduced to allow instances of
WhoCanandActionto becreated. It also modifies the
Checkfunction to no longer calloutputto display the results. Instead,Checkreturns the rolebindings that enable an action to be performed. The call to
outputnowtakes place in the run function for the command.
Overall, this results in no functional changes to the
kubectl-who-canprogram, but allows it to be imported and used from other projects.
Signed-off-by: Bridget McErlean bmcerlean@vmware.com