Skip to content

Conversation

imnotjames
Copy link
Contributor

this PR clarifies what --all-namespaces does and adds this to the README.md

Closes #39

@imnotjames
Copy link
Contributor Author

Hi friends! Does this PR clarify what --all-namespaces does? Let me know, happy to work to improve it with any suggestions!

this clarifies what `--all-namespaces` does and adds
this to the `README.md`
@imnotjames imnotjames force-pushed the techdebt/39/document-all-namespaces-flag branch from 285de56 to 743004a Compare October 17, 2019 21:21
@imnotjames
Copy link
Contributor Author

Hmmm.. something is up with the tests. Digging to understand what failed...

@codecov-io
Copy link

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #45   +/-   ##
======================================
  Coverage    74.8%   74.8%           
======================================
  Files           5       5           
  Lines         381     381           
======================================
  Hits          285     285           
  Misses         84      84           
  Partials       12      12
Impacted Files Coverage Δ
pkg/cmd/list.go 63.34% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2dc899...8dd1edd. Read the comment docs.

Copy link
Contributor

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@lizrice lizrice merged commit e4f3e53 into aquasecurity:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambiguous --all-namespaces flag
3 participants