fix: Bind kube client configuration flags before instantiating a kube client #42
Conversation
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=========================================
- Coverage 75.38% 74.8% -0.59%
=========================================
Files 5 5
Lines 390 381 -9
=========================================
- Hits 294 285 -9
Misses 84 84
Partials 12 12
Continue to review full report at Codecov.
|
pkg/cmd/list.go
Outdated
| }) | ||
| configFlags.AddFlags(cmd.Flags()) | ||
| o.configFlags.AddFlags(cmd.Flags()) |
There was a problem hiding this comment.
I wonder if a simpler fix would have just been to move the lines that were at lines 124-152 to be after these flags have been set up? I don't love the extra complexity of having the separate whoCanOptions struct just to hold the configFlags (but am I missing something?)
… client Resolves: #41
You were right @lizrice It can be done simpler. Thanks for pointing this out. |
Resolves: #41