Skip to content

feat: Resolving API groups #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2019
Merged

feat: Resolving API groups #40

merged 2 commits into from
Jul 8, 2019

Conversation

danielpacak
Copy link
Contributor

@danielpacak danielpacak commented Jul 5, 2019 •
edited
Loading

Resolves: #38 , #35

@codecov-io
Copy link

codecov-io commented Jul 6, 2019 •
edited
Loading

Codecov Report

Merging #40 into master will decrease coverage by <.01%.
The diff coverage is 91.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   75.39%   75.38%   -0.01%     
==========================================
  Files           5        5              
  Lines         382      390       +8     
==========================================
+ Hits          288      294       +6     
- Misses         83       84       +1     
- Partials       11       12       +1
Impacted Files Coverage Δ
pkg/cmd/namespace_validator.go 100% <ø> (ø) ⬆️
pkg/cmd/access_checker.go 100% <ø> (ø) ⬆️
pkg/cmd/list.go 65.08% <100%> (ø) ⬆️
pkg/cmd/policy_rule_matcher.go 93.1% <100%> (+1.26%) ⬆️
pkg/cmd/resource_resolver.go 84.28% <88.88%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01427bc...a2f642c. Read the comment docs.

@danielpacak danielpacak requested a review from lizrice July 8, 2019 07:16
@danielpacak danielpacak added this to the v0.1.0 milestone Jul 8, 2019
lizrice
lizrice approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I had a couple of little comments so just let me know when it's ready to merge.

@danielpacak
feat: Resolve resource API groups
a2f642c 
Kubernetes assigns resources to API grups. So you can have pods
in the core group as well as pods in the metrics.k8s.io groups.
With the changes introduced the plugin allows you to specify the
fully qualified resoruce name at the command line, for example:

$ kubect who-can get pods
$ kubect who-can get pods.metrics.k8s.io

Resolves: #35, #38
@danielpacak danielpacak requested a review from lizrice July 8, 2019 10:56
@lizrice lizrice merged commit 5ab9e06 into aquasecurity:master Jul 8, 2019
@danielpacak danielpacak deleted the issue_38_resolve_api_groups branch July 8, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizrice lizrice Awaiting requested review from lizrice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

Resolve APIGroup
3 participants
@danielpacak @codecov-io @lizrice