Auto Detect Version #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion from viper, and add auto detect docker version for choosing the correct cis + unit tests
Update test var version to be cis-1.2
Add function trimVersion to handle with versions suffix. The check with version.constraints is not working versions prerelease or metadata like docker version 18.09.03-ce
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 45.83% 51.20% +5.36%
==========================================
Files 3 3
Lines 96 125 +29
==========================================
+ Hits 44 64 +20
- Misses 49 54 +5
- Partials 3 7 +4
Continue to review full report at Codecov.
|
itaysk
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change definitions to be under CIS versions name, removed default version from viper, and add auto detect docker version for choosing the correct cis + unit tests