-
Notifications
You must be signed in to change notification settings - Fork 70
Change files to use parameter substitution #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 51.20% 51.51% +0.31%
==========================================
Files 3 3
Lines 125 132 +7
==========================================
+ Hits 64 68 +4
- Misses 54 56 +2
- Partials 7 8 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small things
Remove constraints (unrelated to this PR)
Changed test function name to be TestGetFilePath
Change path and configPath from being global to local
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Change the engine to use parameter substitution and add config.yaml file to each version with /var/docker/lib to cover issue #68