Skip to content

Change files to use parameter substitution #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 19, 2020

Conversation

yoavrotems
Copy link
Contributor

Change the engine to use parameter substitution and add config.yaml file to each version with /var/docker/lib to cover issue #68

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #79 into master will increase coverage by 0.31%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   51.20%   51.51%   +0.31%     
==========================================
  Files           3        3              
  Lines         125      132       +7     
==========================================
+ Hits           64       68       +4     
- Misses         54       56       +2     
- Partials        7        8       +1     
Impacted Files Coverage Δ
app.go 50.00% <61.53%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f5ebc...62f43cf. Read the comment docs.

@yoavrotems yoavrotems mentioned this pull request Jul 2, 2020
@yoavrotems yoavrotems requested a review from simar7 July 5, 2020 07:13
@yoavrotems yoavrotems requested review from danielsagi and removed request for simar7 July 8, 2020 07:25
@lizrice lizrice requested review from lizrice and removed request for danielsagi July 13, 2020 09:11
Copy link
Contributor

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small things

Remove constraints (unrelated to this PR)
Changed test function name to be TestGetFilePath
Change path and configPath from being global to local
@yoavrotems yoavrotems requested a review from lizrice July 14, 2020 17:46
Copy link
Contributor

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yoavrotems yoavrotems merged commit 2a0efff into master Jul 19, 2020
@yoavrotems yoavrotems deleted the add-parameter-substitution branch July 19, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CIS Benchmarks -- Docker Hosts -- 1.1 Ensure a separate patition for containers has been created
2 participants