Skip to content

Add bitmask use #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 14, 2020
Merged

Add bitmask use #74

merged 5 commits into from
Jun 14, 2020

Conversation

yoavrotems
Copy link
Contributor

Update the cfg files to include the option bitmask comparison which will better check files permission when test is #XXX or more restrict #73

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   45.83%   45.83%           
=======================================
  Files           3        3           
  Lines          96       96           
=======================================
  Hits           44       44           
  Misses         49       49           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3125ca6...68cca41. Read the comment docs.

@yoavrotems
Copy link
Contributor Author

could only approved after merging #70
Because it relay on bench-common new release

@yoavrotems yoavrotems requested a review from simar7 June 10, 2020 16:18
Comment on lines 1236 to 1193
If you set one container’s CPU shares to 512 it will receive half of the CPU time compared to
If you set one container’s CPU shares to 512 it will receive half of the CPU time compared to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@yoavrotems yoavrotems requested review from simar7 and danielsagi and removed request for simar7 June 14, 2020 11:33
Copy link

@danielsagi danielsagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@yoavrotems yoavrotems merged commit be889b0 into master Jun 14, 2020
@lizrice lizrice deleted the add-bitmask-use branch December 17, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants