Fix issues about daemon.json #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
=======================================
Coverage 45.83% 45.83%
=======================================
Files 3 3
Lines 96 96
=======================================
Hits 44 44
Misses 49 49
Partials 3 3 Continue to review full report at Codecov.
|
simar7
reviewed
Jun 10, 2020
cfg/18.09/definitions.yaml
Outdated
Comment on lines
1236
to
1380
| If you set one container’s CPU shares to 512 it will receive half of the CPU time compared to | ||
| If you set one container’s CPU shares to 512 it will receive half of the CPU time compared to |
There was a problem hiding this comment.
Yes, let me change it back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update cfg files in order to check daemon.json file as well.
Changes are according to CIS, where in notes has the following comment
(XXX is the different parameter between tests)
Addressing issues #64 #65 #66 #67 and some more tests