Skip to content

Add goreleaser #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2020
Merged

Add goreleaser #59

merged 3 commits into from
Jan 9, 2020

Conversation

yoavrotems
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 29, 2019

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   45.83%   45.83%           
=======================================
  Files           3        3           
  Lines          96       96           
=======================================
  Hits           44       44           
  Misses         49       49           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a92100...7a4ce81. Read the comment docs.

@yoavrotems
Copy link
Contributor Author

As requested in #33

@lizrice lizrice requested a review from danielpacak January 3, 2020 11:38
Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config yaml files look fine. Before you run the actual release by creating an annotated tag make sure that:

  1. You add dist dir to .gitignore. Otherwise goreleaser might complain about git working directory with uncommitted changes.
  2. Make sure that you add GITHUB_TOKEN env in travis config https://travis-ci.com/aquasecurity/docker-bench/settings. The token must have the repo scope to deploy the artifacts to GitHub releases page https://github.com/aquasecurity/docker-bench/releases. Alternatively you can encode the GITHUB_TOKEN in .travis.yaml with travis CLI.

@danielpacak danielpacak self-requested a review January 8, 2020 11:09
@danielpacak
Copy link
Contributor

Approving. Heads up to rename Goreleaser_token env in Travis to GITHUB_TOKEN before you actually perform a release.

@yoavrotems
Copy link
Contributor Author

Changed to GITHUB_TOKEN

@danielpacak danielpacak merged commit 27a0d33 into master Jan 9, 2020
@lizrice lizrice deleted the add-goreleaser branch December 17, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants