Add support for new 18.09 version #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
=======================================
Coverage 45.83% 45.83%
=======================================
Files 3 3
Lines 96 96
=======================================
Hits 44 44
Misses 49 49
Partials 3 3Continue to review full report at Codecov.
|
Double-check and running the yaml inside a testing environment . All seems to work fine
lizrice
suggested changes
Nov 22, 2019
Remove comments about changes that need to be made, and will make a new PR reviewing those because the changes will apply to older versions as well
lizrice
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a draft pr for updating the new 18.09 version.
All seems good but still need to test some checks to make sure there is no false positive or anything that works incorrectly.