Add Codecov #42
Merged
Add Codecov #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add to ignore coverage.txt
Added to help run codecov
Add Codecov badge
Add makefile for codecov tests
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=========================================
Coverage ? 45.83%
=========================================
Files ? 3
Lines ? 96
Branches ? 0
=========================================
Hits ? 44
Misses ? 49
Partials ? 3Continue to review full report at Codecov.
|
danielpacak
suggested changes
Aug 7, 2019
There was a problem hiding this comment.
Hey @yoavrotems . Good job. I've left some comments though.
In longer term I would suggest using GO1111MODS explicitly, i.e. go mod init in docker-bench and the same for bench-common. Otherwise the go.mod file is created on Travis while executing tests. go.mod should be version with explicit dependencies. @lizrice WDYT?
danielpacak
reviewed
Aug 7, 2019
danielpacak
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.