fix(misconf): add missing variable as unknown #8683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
simar7
reviewed
Apr 7, 2025
Comment on lines
342
to
346
| p.logger.Warn( | ||
| "Variable values was not found in the environment or variable files. Evaluating may not work correctly.", | ||
| log.String("variables", strings.Join(missingVars, ", ")), | ||
| ) | ||
| } |
There was a problem hiding this comment.
Suggested change
| p.logger.Warn( | |
| "Variable values was not found in the environment or variable files. Evaluating may not work correctly.", | |
| log.String("variables", strings.Join(missingVars, ", ")), | |
| ) | |
| } | |
| p.logger.Warn( | |
| "Variable values were not found in the environment or variable files. Evaluating may not work correctly.", | |
| log.String("variables", strings.Join(missingVars, ", ")), | |
| ) | |
| } |
simar7
reviewed
Apr 7, 2025
| if !ctyVal.IsKnown() || ctyVal.IsNull() { | ||
| if ctyVal.IsNull() { |
There was a problem hiding this comment.
Is there any benefit to using .IsWhollyKnown() here?
There was a problem hiding this comment.
I think not, since IsWhollyKnown checks that complex types are fully known, such as lists or objects, which would prevent us from using only some elements of those types if needed. Also, I don't see the benefit of returning DynamicVal when the value is unknown, as it results in type erasure.
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
simar7
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See issue description
Related issues
Checklist